-
Notifications
You must be signed in to change notification settings - Fork 2
BEG-223: Add session expiry warning modal #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aligent-lturner
merged 7 commits into
main
from
feature/BEG-223_Add_session_expiry_warning_modal
Oct 21, 2025
Merged
BEG-223: Add session expiry warning modal #15
aligent-lturner
merged 7 commits into
main
from
feature/BEG-223_Add_session_expiry_warning_modal
Oct 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshaaligent
previously approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aligent-lturner
previously requested changes
Oct 7, 2025
|
@quangdo-aligent I've pushed some changes, so I can't review this now - can you take a look when you've got a second? |
I've now made changes, so someone else will need to review
quangdo-aligent
previously approved these changes
Oct 21, 2025
quangdo-aligent
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request in #14 , this feature provides an admin UI modal that warns the admin user if they're within one minute of their session expiring.
I've taken a simple approach in the phtml file, but open to suggestions for improvement.